Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ref assembly output part1 #1

Merged
merged 122 commits into from
Dec 26, 2021
Merged

Conversation

alfonsogarciacaro
Copy link
Owner

@alfonsogarciacaro alfonsogarciacaro commented Dec 26, 2021

TIHan and others added 29 commits November 4, 2021 12:37
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Add `WarningsNotAsErrors`
to be forwarded to the compiler
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…126.2 (dotnet#12459)

Microsoft.DotNet.Arcade.Sdk
 From Version 7.0.0-beta.21574.3 -> To Version 7.0.0-beta.21576.2

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
… Build ID 1487500 (dotnet#12461)

* Localized file check-in by OneLocBuild Task: Build definition ID 499: Build ID 1487500

* Localized file check-in by OneLocBuild Task: Build definition ID 499: Build ID 1487500
…126.4 (dotnet#12462)

Microsoft.DotNet.Arcade.Sdk
 From Version 7.0.0-beta.21576.2 -> To Version 7.0.0-beta.21576.4

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* Allow IsByRefLikeAttribute to be specified in user code or a non-framework assembly.

And use isByrefLikeTyconRef instead of specifically checking whether the attribute is applied.
A post-inference check about this attribute was moved to the aforementioned function.

* Fix a typo.

* Remove some leftover code that was causing errors.

And use tname_IsByRefLikeAttribute without the TcGlobals qualification.

* Handle the ILTypeSpec.Enclosing property correctly.

It wasn't holding the namespace's components but the inner types if it was nested. The project now builds.

* Test that custom IsByRefLikeAttributes are recognized.

* Fix one failing test.

* Fix another failing test.

* Address PR feedback: move a check back to PostInferenceChecks.fs.

* Add another test.
* Update dependencies from https://github.com/dotnet/arcade build 20211202.3

Microsoft.DotNet.Arcade.Sdk
 From Version 7.0.0-beta.21576.4 -> To Version 7.0.0-beta.21602.3

* Update dependencies from https://github.com/dotnet/arcade build 20211203.6

Microsoft.DotNet.Arcade.Sdk
 From Version 7.0.0-beta.21576.4 -> To Version 7.0.0-beta.21603.6

* Update dependencies from https://github.com/dotnet/arcade build 20211206.6

Microsoft.DotNet.Arcade.Sdk
 From Version 7.0.0-beta.21576.4 -> To Version 7.0.0-beta.21606.6

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
@alfonsogarciacaro alfonsogarciacaro merged commit 77ec4d0 into service_slim Dec 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants